Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwardcompatibility #35

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

jlamaille
Copy link
Contributor

The goal is to add the notion of non-retro compatibility of changes with a visible rendering on the html part.

I added unit tests.

I still have the readme to update I do it right now.

@jlamaille
Copy link
Contributor Author

You can also see the non-backwards compatible changes

@jlamaille jlamaille changed the title Backwardcompatibility WIP:Backwardcompatibility Jun 29, 2020
@jlamaille jlamaille changed the title WIP:Backwardcompatibility Backwardcompatibility Jun 29, 2020
@jlamaille
Copy link
Contributor Author

Okay to merge for me.

@Sayi
Copy link
Owner

Sayi commented Jul 2, 2020

Hi, You are awesome!

I have seen the code submitted many times and you modified 40+ files, can you describe in detail which features have been added?

@jlamaille
Copy link
Contributor Author

Hi,

Thank you.

  • I added the notion of backwards compatibility check or not of the interface contract.
  • Added lombok for the auto generated getter and setter.
  • A few small renames
  • Add unit tests

I think that's all.

On the other hand I see that the maven install is done with an open jdk 11, it's normal? because it looks like it's stuck on lombok precisely.

@jlamaille
Copy link
Contributor Author

I'm thinking of adding an option on the standard output to bring up the notion of backward compatibility or not if you want to go through the command.
I can make a pull request if this one is merged in the meantime.

@jlamaille
Copy link
Contributor Author

finally I think the use of the json format is enough.
I think a proofreading of the code would be welcome before the mege.
I'm available to fix if things go wrong.

@jlamaille
Copy link
Contributor Author

image

The build does not pass with the lombok 1.16.X version compatible with jdk8
It passes with the lombok 1.18.X because it builds in travis with an openJdk 11.

On the other hand the project is declared in jdk1.8 cf my capture so I don't know what to do :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants